Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Podspec #44

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Podspec #44

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72329a1
Removed ToolTipTests
marcosrodriguezturner Feb 22, 2019
246c4af
Add Podspec
marcosrdz Apr 11, 2019
6df46e2
Fixed Podspec
marcosrdz Apr 13, 2019
e0e88d2
Update ToolTipMenu.podspec
marcosrdz Oct 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 22 additions & 0 deletions ToolTipMenu.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
require 'json'

package = JSON.parse(File.read(File.join(__dir__, 'package.json')))

Pod::Spec.new do |s|
s.name = "ToolTipMenu"
s.version = package['version']
s.summary = package['description']
s.license = package['license']

s.authors = package['author']
s.homepage = package['repository']['url']
s.platform = :ios, "10.0"
s.ios.deployment_target = '10.0'
s.tvos.deployment_target = '10.0'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR and your fork! Needed on RN 0.60 as it's requiring pods as default, and packages not using pods run into 'React/RCTViewManager.h' file not found issues.

However, your ios target version of 10.0 is higher than need be. On running pod update, I get this error:

[!] CocoaPods could not find compatible versions for pod "ToolTipMenu":
  In Podfile:
    ToolTipMenu (from `../node_modules/react-native-tooltip`)

Specs satisfying the `ToolTipMenu (from `../node_modules/react-native-tooltip`)` dependency were found, but they required a higher minimum deployment target.

I patch-package'ed your fork to delete the above 2 lines with deployment_target, and changed s.platform to 9.0. Like https://github.com/react-native-community/react-native-webview/blob/master/react-native-webview.podspec as reference podspec. Then pod update runs fine.


s.source = { :git => "https://github.com/marcosrdz/react-native-tooltip.git", :tag => "#{s.version}" }
s.preserve_paths = '*'
s.source_files = "ToolTipMenu/*.{h,m}"

s.dependency 'React'
end
111 changes: 0 additions & 111 deletions ToolTipMenu.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,10 @@
/* Begin PBXBuildFile section */
4681C0251B05271A004D67D4 /* ToolTipMenu.h in CopyFiles */ = {isa = PBXBuildFile; fileRef = 4681C0241B05271A004D67D4 /* ToolTipMenu.h */; };
4681C0271B05271A004D67D4 /* ToolTipMenu.m in Sources */ = {isa = PBXBuildFile; fileRef = 4681C0261B05271A004D67D4 /* ToolTipMenu.m */; };
4681C02D1B05271A004D67D4 /* libToolTipMenu.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 4681C0211B05271A004D67D4 /* libToolTipMenu.a */; };
469F58B71B069FF300C571E8 /* RCTToolTipText.m in Sources */ = {isa = PBXBuildFile; fileRef = 469F58B61B069FF300C571E8 /* RCTToolTipText.m */; };
469F58B91B06A00C00C571E8 /* RCTToolTipTextManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 469F58B81B06A00C00C571E8 /* RCTToolTipTextManager.m */; };
/* End PBXBuildFile section */

/* Begin PBXContainerItemProxy section */
4681C02E1B05271A004D67D4 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
containerPortal = 4681C0191B05271A004D67D4 /* Project object */;
proxyType = 1;
remoteGlobalIDString = 4681C0201B05271A004D67D4;
remoteInfo = ToolTipMenu;
};
/* End PBXContainerItemProxy section */

/* Begin PBXCopyFilesBuildPhase section */
4681C01F1B05271A004D67D4 /* CopyFiles */ = {
isa = PBXCopyFilesBuildPhase;
Expand All @@ -41,7 +30,6 @@
4681C0211B05271A004D67D4 /* libToolTipMenu.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = libToolTipMenu.a; sourceTree = BUILT_PRODUCTS_DIR; };
4681C0241B05271A004D67D4 /* ToolTipMenu.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = ToolTipMenu.h; sourceTree = "<group>"; };
4681C0261B05271A004D67D4 /* ToolTipMenu.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = ToolTipMenu.m; sourceTree = "<group>"; };
4681C02C1B05271A004D67D4 /* ToolTipMenuTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = ToolTipMenuTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
4681C0321B05271A004D67D4 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
469F58B31B069F9800C571E8 /* RCTToolTipText.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RCTToolTipText.h; sourceTree = "<group>"; };
469F58B61B069FF300C571E8 /* RCTToolTipText.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = RCTToolTipText.m; sourceTree = "<group>"; };
Expand All @@ -57,14 +45,6 @@
);
runOnlyForDeploymentPostprocessing = 0;
};
4681C0291B05271A004D67D4 /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
4681C02D1B05271A004D67D4 /* libToolTipMenu.a in Frameworks */,
);
runOnlyForDeploymentPostprocessing = 0;
};
/* End PBXFrameworksBuildPhase section */

/* Begin PBXGroup section */
Expand All @@ -81,7 +61,6 @@
isa = PBXGroup;
children = (
4681C0211B05271A004D67D4 /* libToolTipMenu.a */,
4681C02C1B05271A004D67D4 /* ToolTipMenuTests.xctest */,
);
name = Products;
sourceTree = "<group>";
Expand Down Expand Up @@ -135,24 +114,6 @@
productReference = 4681C0211B05271A004D67D4 /* libToolTipMenu.a */;
productType = "com.apple.product-type.library.static";
};
4681C02B1B05271A004D67D4 /* ToolTipMenuTests */ = {
isa = PBXNativeTarget;
buildConfigurationList = 4681C0381B05271A004D67D4 /* Build configuration list for PBXNativeTarget "ToolTipMenuTests" */;
buildPhases = (
4681C0281B05271A004D67D4 /* Sources */,
4681C0291B05271A004D67D4 /* Frameworks */,
4681C02A1B05271A004D67D4 /* Resources */,
);
buildRules = (
);
dependencies = (
4681C02F1B05271A004D67D4 /* PBXTargetDependency */,
);
name = ToolTipMenuTests;
productName = ToolTipMenuTests;
productReference = 4681C02C1B05271A004D67D4 /* ToolTipMenuTests.xctest */;
productType = "com.apple.product-type.bundle.unit-test";
};
/* End PBXNativeTarget section */

/* Begin PBXProject section */
Expand All @@ -165,9 +126,6 @@
4681C0201B05271A004D67D4 = {
CreatedOnToolsVersion = 6.3.1;
};
4681C02B1B05271A004D67D4 = {
CreatedOnToolsVersion = 6.3.1;
};
};
};
buildConfigurationList = 4681C01C1B05271A004D67D4 /* Build configuration list for PBXProject "ToolTipMenu" */;
Expand All @@ -183,21 +141,10 @@
projectRoot = "";
targets = (
4681C0201B05271A004D67D4 /* ToolTipMenu */,
4681C02B1B05271A004D67D4 /* ToolTipMenuTests */,
);
};
/* End PBXProject section */

/* Begin PBXResourcesBuildPhase section */
4681C02A1B05271A004D67D4 /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
/* End PBXResourcesBuildPhase section */

/* Begin PBXSourcesBuildPhase section */
4681C01D1B05271A004D67D4 /* Sources */ = {
isa = PBXSourcesBuildPhase;
Expand All @@ -209,23 +156,8 @@
);
runOnlyForDeploymentPostprocessing = 0;
};
4681C0281B05271A004D67D4 /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
);
runOnlyForDeploymentPostprocessing = 0;
};
/* End PBXSourcesBuildPhase section */

/* Begin PBXTargetDependency section */
4681C02F1B05271A004D67D4 /* PBXTargetDependency */ = {
isa = PBXTargetDependency;
target = 4681C0201B05271A004D67D4 /* ToolTipMenu */;
targetProxy = 4681C02E1B05271A004D67D4 /* PBXContainerItemProxy */;
};
/* End PBXTargetDependency section */

/* Begin XCBuildConfiguration section */
4681C0331B05271A004D67D4 /* Debug */ = {
isa = XCBuildConfiguration;
Expand Down Expand Up @@ -326,40 +258,6 @@
};
name = Release;
};
4681C0391B05271A004D67D4 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
FRAMEWORK_SEARCH_PATHS = (
"$(SDKROOT)/Developer/Library/Frameworks",
"$(inherited)",
);
GCC_PREPROCESSOR_DEFINITIONS = (
"DEBUG=1",
"$(inherited)",
);
INFOPLIST_FILE = ToolTipMenuTests/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = "cj.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = "$(TARGET_NAME)";
};
name = Debug;
};
4681C03A1B05271A004D67D4 /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
FRAMEWORK_SEARCH_PATHS = (
"$(SDKROOT)/Developer/Library/Frameworks",
"$(inherited)",
);
INFOPLIST_FILE = ToolTipMenuTests/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = "cj.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = "$(TARGET_NAME)";
};
name = Release;
};
/* End XCBuildConfiguration section */

/* Begin XCConfigurationList section */
Expand All @@ -381,15 +279,6 @@
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
4681C0381B05271A004D67D4 /* Build configuration list for PBXNativeTarget "ToolTipMenuTests" */ = {
isa = XCConfigurationList;
buildConfigurations = (
4681C0391B05271A004D67D4 /* Debug */,
4681C03A1B05271A004D67D4 /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
/* End XCConfigurationList section */
};
rootObject = 4681C0191B05271A004D67D4 /* Project object */;
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-tooltip",
"version": "5.2.0",
"version": "5.2.1",
"description": "A react-native wrapper for showing tooltips",
"main": "ToolTip.ios.js",
"author": {
Expand Down