Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podspec #44

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Podspec #44

wants to merge 4 commits into from

Conversation

marcosrdz
Copy link

No description provided.

s.homepage = package['repository']['url']
s.platform = :ios, "10.0"
s.ios.deployment_target = '10.0'
s.tvos.deployment_target = '10.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR and your fork! Needed on RN 0.60 as it's requiring pods as default, and packages not using pods run into 'React/RCTViewManager.h' file not found issues.

However, your ios target version of 10.0 is higher than need be. On running pod update, I get this error:

[!] CocoaPods could not find compatible versions for pod "ToolTipMenu":
  In Podfile:
    ToolTipMenu (from `../node_modules/react-native-tooltip`)

Specs satisfying the `ToolTipMenu (from `../node_modules/react-native-tooltip`)` dependency were found, but they required a higher minimum deployment target.

I patch-package'ed your fork to delete the above 2 lines with deployment_target, and changed s.platform to 9.0. Like https://github.com/react-native-community/react-native-webview/blob/master/react-native-webview.podspec as reference podspec. Then pod update runs fine.

@jeremyeaton89
Copy link

This ready to go @chirag04 @fungilation ? Seeing warnings about this. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants