Remove non-serializable objects from error.userData when request fails #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirag04
reviewed
Jul 25, 2017
| if (callback) { | ||
| // Ensure error.userData can be converted to JSON without error. | ||
| // This will remove any NSURL from the error.userData. | ||
| error = RCTErrorClean(error); |
There was a problem hiding this comment.
this should be upstream in react-native? they should handle NSURL in RCTJSErrorFromNSError?
There was a problem hiding this comment.
Ideally, but upstreaming it and waiting for merge will take pretty long and till then this method will crash.
I will try to get fb to merge a change to support NSURL too
There was a problem hiding this comment.
agreed. let's get a PR upstream. once it's merged upstream, we can add a fallback here. If it's not merged upstream in x time, then let's ship here.
that works for you?
|
@akshetpandey any update? |
|
@akshetpandey ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error.userData may contain NSURL which doesn't serialize and causes a crash.