Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send "user_cancelled" error #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RalfNieuwenhuizen
Copy link
Contributor

Send "user_cancelled" error instead of "Cannot connect to iTunes Store" upon cancellation

@raduflp
Copy link

raduflp commented Nov 28, 2017

@chirag04 could you have a look at this and maybe merge it?
in my case it solves the issue of app crashing when user cancels a purchase

@chirag04
Copy link
Owner

you this logic live in JS and in your product? regardless, you would have a if to check if user_cancelled. so might as well check for transaction code?

@raduflp
Copy link

raduflp commented Dec 1, 2017

in my case for the user canceled scenario I could not capture a response or error in the JS jogic, even when surrounding the statements with try catch. It would always silently throw the error on the native side and crash the app.

Maybe someone else could test this scenario and share their experience

@chirag04
Copy link
Owner

chirag04 commented Dec 1, 2017

i'm guessing you are hit by this one: #109

can you confirm the native error?

@gontovnik
Copy link

@raduflp, @chirag04 any update on this? I need this change to be merged. Currently, there is no way to identify whether the transaction really failed or was canceled by the user.

@soheilpro
Copy link

Any plans to merge this?

I need to know whether the transaction was canceled by the user or there was an error.

@nztf
Copy link

nztf commented Oct 25, 2019

+1 to this feature request
Now I'm using fork with this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants