Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping compilation on jdk7 due to lack of support on trusty. #236

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dropping compilation on jdk7 due to lack of support on trusty. #236

wants to merge 2 commits into from

Commits on Nov 9, 2017

  1. Switching oraclejdk7 to openjdk7 due to lack of support on trusty. 

    This is addressed in [a github issue on the matter][1], summarised in
that all builds run on trusty that use `oraclejdk7` as their jdk will
categorically fail.

[1]: travis-ci/travis-ci#7019 (comment)
    pcummuskey committed Nov 9, 2017
    Configuration menu
    Copy the full SHA
    0bba31c View commit details
    Browse the repository at this point in the history

  2. Fixing an SSL issue by removing jdk7 support altogether. 

    Near the end of [this thread][1] it says that there's a workaround/fix
involving build scripts [like this][2], or a docker build
[like this][3].

The cost/benefit of implementing any of these options is higher than
that of simply removing support and freeing up a ton of broken builds,
so that's the fix contained in this commit.

[1]: https://www.bountysource.com/issues/47030823-when-plugin-id-specified-gradle-tasks-results-in-java-security-invalidkeyexception-ec-parameters-error
[2]: https://github.com/uber-java/tally/blob/2cea75ecc2f896dfd5e32b94bff71f211c8bde56/ci/before_install.sh#L6-L12
[3]: travis-ci/travis-ci#8503 (comment)
    pcummuskey committed Nov 9, 2017
    Configuration menu
    Copy the full SHA
    1fbd1fd View commit details
    Browse the repository at this point in the history