Dropping compilation on jdk7 due to lack of support on trusty. #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is addressed in [a github issue on the matter][1], summarised in that all builds run on trusty that use `oraclejdk7` as their jdk will categorically fail. [1]: travis-ci/travis-ci#7019 (comment)
|
Whelp, that one took me by surprise. Guess I have to figure out why gradle can't handle openjdk7 now. Or support could be dropped for it? |
|
Actually, near the end of this thread it basically says that there's a workaround involving build scripts like this, or a docker build like this. |
Near the end of [this thread][1] it says that there's a workaround/fix involving build scripts [like this][2], or a docker build [like this][3]. The cost/benefit of implementing any of these options is higher than that of simply removing support and freeing up a ton of broken builds, so that's the fix contained in this commit. [1]: https://www.bountysource.com/issues/47030823-when-plugin-id-specified-gradle-tasks-results-in-java-security-invalidkeyexception-ec-parameters-error [2]: https://github.com/uber-java/tally/blob/2cea75ecc2f896dfd5e32b94bff71f211c8bde56/ci/before_install.sh#L6-L12 [3]: travis-ci/travis-ci#8503 (comment)
Tzrlk
changed the title
|
Can this be merged-in asap @norbertpotocki? Other merge request builds are registering as failed because the travis build environment for jdk7 no-longer works. There are other options available (as mentioned in my comments above), but this takes care of it immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addressed in a github issue on the matter, summarised in
that all builds run on trusty that use
oraclejdk7as their jdk willcategorically fail.