Replace boulder tests with pebble #9918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wgreenberg, are you ready for a review on this? just let me know when you are and i'll take a look |
|
@bmw just about! need to fix some bits around how we invoke pebble, but that shouldn't take too long |
Since this argument is never set and always defaults to 'pebble', just remove it to simplify assumptions about which test server's being used.
Now that pebble supports all of our test cases, we can move off of the much more complicated boulder test harness.
|
@bmw aaand finally, this is ready for review. |
bmw
requested changes
May 2, 2024
There was a problem hiding this comment.
nice work!
i initially just started to approve this and submit a follow up PR with a few minor nitpicks for you to take or leave, but i thought it'd be slightly nice to avoid the unnecessary churn on the custom http-01-port and proxy condition if i'm understanding that code correctly
otherwise, this LGTM
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
|
79 added lines to 376 deleted lines is pretty damn good imo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pebble 2.5.1 supports OCSP stapling, so we can finally replace all boulder tests/harnesses with the much simpler pebble setup.
Closes #9898