Switch to using docker compose v2 #9926
Conversation
Azure recently dropped the `docker-compose` standalone executable (aka docker-compose v1), and since it's not receiving updates anymore, let's get with the times and update to v2 as well.
|
i did some ci config mangling at https://dev.azure.com/certbot/certbot/_build/results?buildId=7596&view=results to see if this works since we don't run boulder tests on PRs for better or worse |
| @@ -89,10 +89,11 @@ def _setup_primary_node(config): | |||
| 'boulder, but is not installed or not available for current user.') | |||
|
|
|||
| try: | |||
| subprocess.check_output(['docker-compose', '-v'], stderr=subprocess.STDOUT) | |||
| subprocess.check_output(['docker', 'compose', 'ps'], stderr=subprocess.STDOUT) | |||
There was a problem hiding this comment.
looks like the test run i kicked off failed. maybe try docker compose ls here? docker compose ps fails for me locally if there's not a docker-compose.yml file in the current working directory
certbot/CHANGELOG.md
Outdated
| @@ -16,6 +16,7 @@ Certbot adheres to [Semantic Versioning](https://semver.org/). | |||
|
|
|||
| * We no longer publish our beta Windows installer as was originally announced | |||
| [here](https://community.letsencrypt.org/t/certbot-discontinuing-windows-beta-support-in-2024/208101). | |||
| * Switch to using docker compose v2, as Azure's images dropped v1. | |||
There was a problem hiding this comment.
we can keep it if ya want, but i'd suggest removing this since this isn't user facing and just affects our internal ci stuff
certbot/docs/contributing.rst
Outdated
| @@ -154,7 +154,7 @@ Running automated integration tests | |||
|
|
|||
| Generally it is sufficient to open a pull request and let Github and Azure Pipelines run | |||
| integration tests for you. However, you may want to run them locally before submitting | |||
| your pull request. You need Docker and docker-compose installed and working. | |||
| your pull request. You need Docker and docker-compose (v1 or v2) installed and working. | |||
There was a problem hiding this comment.
is it true that v1 still works?
if so, feel free to keep this as is, but i actually think we can probably just delete the docker-compose requirement here. we required docker-compose here once upon a time, but we actually no longer require it for pebble which is what's being used in the description below and your work in #9918 exists
There was a problem hiding this comment.
aha, you're very right. removing!
Azure recently dropped the
docker-composestandalone executable (aka docker-compose v1), and since it's not receiving updates anymore, let's get with the times and update to v2 as well.