New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace boulder tests with pebble #9918
Conversation
@wgreenberg, are you ready for a review on this? just let me know when you are and i'll take a look |
@bmw just about! need to fix some bits around how we invoke pebble, but that shouldn't take too long |
Since this argument is never set and always defaults to 'pebble', just remove it to simplify assumptions about which test server's being used.
Now that pebble supports all of our test cases, we can move off of the much more complicated boulder test harness.
@bmw aaand finally, this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
i initially just started to approve this and submit a follow up PR with a few minor nitpicks for you to take or leave, but i thought it'd be slightly nice to avoid the unnecessary churn on the custom http-01-port and proxy condition if i'm understanding that code correctly
otherwise, this LGTM
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
79 added lines to 376 deleted lines is pretty damn good imo |
Pebble 2.5.1 supports OCSP stapling, so we can finally replace all boulder tests/harnesses with the much simpler pebble setup.
Closes #9898