Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ALT mode to Throttle/Mixture levers #1498

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hbeni
Copy link
Contributor

@hbeni hbeni commented Mar 12, 2024

Pressing ALT and moving the levers (mousewheel/dragging) gives finer control now.
This simulates throttles friction lock and the mixtures vernier feature.

Pressing ALT and moving the levers (mousewheel/dragging) gives finer control now.
This simulates throttles friction lock and the mixtures vernier feature.
@hbeni
Copy link
Contributor Author

hbeni commented Mar 12, 2024

I have seen, the default movement step is 2%.
The C182 uses 5% which may be a little better?

If you like, I can adjust it to match.

@wlbragg
Copy link
Collaborator

wlbragg commented Mar 12, 2024

So without "ALT" it will be a faster travel if you change it to 5, but with "ALT" you can get a slow more precise adjustment?

If this is so, yes, go ahead.

@hbeni
Copy link
Contributor Author

hbeni commented Mar 12, 2024

So without "ALT" it will be a faster travel if you change it to 5, but with "ALT" you can get a slow more precise adjustment?

Currently it is so:

  • shift usage = 10% steps
  • Just use = 2% steps
  • alt usage = 1% steps (introduced by this PR)

I propose to change „Just use = 2% steps“ to 5% increments. This essentially results in shift doubling and alt halving the „normal“ travel.

If this is so, yes, go ahead.

  • okay 👍

EDIT 1: btw, Shift+Alt combines, resulting in 2% steps (so shift can double the "fine adjustment value").
EDIT 2: and also btw, shift and alt also work with dragging and mouse wheel usage (the later was my initial incentive wanting to change this).

- Shift usage now still does 10% increments
- Alt usage does 1% increments
- combining alt+shift results in 2% steps
- This applies also to dragging and mouse wheel scrolling

(It is in sync with the C182 now; see HHS81/c182s#571 )
@hbeni
Copy link
Contributor Author

hbeni commented Mar 12, 2024

What I wonder tough: where do we document the different use modes of the levers, so pilots will see them?

@wkitty42
Copy link
Contributor

wkitty42 commented Mar 12, 2024 via email

@hbeni
Copy link
Contributor Author

hbeni commented Mar 12, 2024

Hm, or maybe directly at the tooltip?
Or just the wiki?

I tried adding it at the help gui, but that looked not so good.

@wkitty42
Copy link
Contributor

wkitty42 commented Mar 12, 2024 via email

@hbeni
Copy link
Contributor Author

hbeni commented Mar 13, 2024

For the 182 I added a Dicumentation.md file years ago, to collect feature descriptions etc.

@wkitty42
Copy link
Contributor

wkitty42 commented Mar 13, 2024 via email

@hbeni
Copy link
Contributor Author

hbeni commented Mar 13, 2024

No, but we have an "about the plane" dialog, featuring buttons to open links:
grafik

There, a link to the github markdown file could be added, because that will open the file directly parsed.
But: It needs internet access. That is a bad thing.
Maybe we should add some markdown parser widget to display markdown in canvas dialogs; that way we could make this easy and generic.

EDIT: Just asked the MD thingy on the ML.

@wkitty42
Copy link
Contributor

wkitty42 commented Mar 13, 2024

Hm, or maybe directly at the tooltip? Or just the wiki?

I tried adding it at the help gui, but that looked not so good.

i don't know how you added it but i was thinking of something like this...
c172p-proposed-craft-help-dialog-Screenshot_20240313_120252
but with better wording than i show here... maybe also with a divider line below this new section to separate it from the checklist line...

i whipped this up with the following...

diff --git a/c172-help.xml b/c172-help.xml
index f55b7a57..bb35528d 100644
--- a/c172-help.xml
+++ b/c172-help.xml
@@ -79,6 +79,13 @@
         <desc>Reset view</desc>
     </key>
 
+    <line/>
+    <line>to adjust throttle and mixture, drag or mousewheel on them.</line>
+    <line>using no modifier keys, they will move at a rate of 5% of their total length.</line>
+    <line>using SHIFT, they will move at a rate of 10% of their total length.</line>
+    <line>using ALT, they will move at a rate of 1% of their total length.</line>
+    <line>using SHIFT and ALT, they will move at double the ALT rate.</line>
+
     <line/>
     <line>For checklists, see under Help-&gt;Aircraft Checklists</line>
     <line/>

maybe use leading dashes on each of the "using [...]" lines so it looks like an unordered list would help, too...

also, perhaps this may be a nice feature to add to the air vent (top left of windshield), cabin heat, and cabin air (both on bottom right of dashboard) as well? i think that's all the sliding controls, isn't it?

@wkitty42
Copy link
Contributor

maybe use leading dashes on each of the "using [...]" lines so it looks like an unordered list would help, too...

would look like this...
c172p-proposed-craft-help-dialog-with-unordered-list-look-Screenshot_20240313_120252

@wlbragg
Copy link
Collaborator

wlbragg commented Mar 13, 2024

After looking at the available GUI help categories, I think it belongs in Common Aircraft Keys.

First I wish we either also had a Custom Aircraft Keys category or the Common Aircraft Keys heading was changed to simply, Aircraft Keys. I think you could just add the extra two key combinations in that list of keys. That is the most likely place it will be seen by the user IMHO. It's only two or three more line items, right? Well actually as many as six including both the throttle and mixture.

@wkitty42
Copy link
Contributor

wkitty42 commented Mar 13, 2024 via email

@wlbragg
Copy link
Collaborator

wlbragg commented Mar 13, 2024

idk... i see Common Aircraft Keys as being common to all craft whereas this is a
feature we're adding to the c172p so it is specific to the c172p like it is
specific to Hbeni's craft...

But that is one of the first places someone will look to quickly get the key bindings. Also this whole concept of "Common Aircraft Keys", that was my point. When does it become common, one, two, 10 or more aircraft? The throttle and mixture are common to almost every aircraft. These are just modifiers to those common controls. Again. I think we need a core change and remove the word Common. If we are to keep "Common", then we need another heading such as "Custom Keys". I don't think it is necessary or proper to limit what goes in the quickest help popup for an individual aircraft to the word "common" I think it is just legacy wording that is past time for a change.

Also you can't be sure that it will not become "common" to many other aircraft once developers see it in use and start to adopt it.

One more thing, we already have seat position keys in this help dialog, they are by no means "common" to other aircraft.

@wkitty42
Copy link
Contributor

wkitty42 commented Mar 13, 2024

i didn't realize the seat position keys were in the Common Keys menu... i thought they were in the "?" menu specific to each craft... but, i do see what you are saying about throttle and mixture being common... i've always seen that menu as common to all craft with feature or special stuff being in the "?" menu for each craft...

i don't know at what point something would be know as "common"... we face this same question in an old-school network where "things in common practice" are what is documented... in a network with thousands of systems that can connect to each other, at will, and exchange messages and files, "common handshakes", "common transfer protocols", and similar are used... at what point each of the various handshakes and protocols were """counted""" and passed some "boundary" to become "common" i don't know even though i was there and part of the process...

anyway, i'm offering a POV with thoughts and ideas... you all are the implementers asking for input... i offer my input freely and leave it to you all to consider it and do with it what you will 👍

@wlbragg
Copy link
Collaborator

wlbragg commented Mar 13, 2024

i thought they were in the "?" menu specific to each craft...

Ah, that is the menu I was referring to. I guess i got confused. I see no problem putting it in there, in the same place as the seat position keys.

The "Common Aircraft Keys" is swollen and has grown. Is that custom to each aircraft or is it stored in fgdata? If it is in fgdata, then yes, I don't think it should go there. Also, having the "?" menu is basically the same thing as an aircraft specific heading. I'm not sure I ever look at that though, I think I am more likely to check the Common Aircraft Keys. But the Aircraft Help "?" certainly the appropriate place. Any idea why the "?" is there? Is the universal to "help" screens?

@wkitty42
Copy link
Contributor

yeah, looking briefly at the menubar code, i see nasal is used to display /sim/help and /sim/help/common... the only text line in /sim/help/common is the title line... the "?" menu comes from /sim/help and i do see that my testing modification (above) is loaded in there... i haven't gone digging far enough to figure out how and when the text is loaded from the xml file... i would have to dig a lot deeper to figure out where the "common" help is loaded from... looking at the xml files in fgdata's "gui" directory doesn't show me anything obvious in the filenames indicating that file...

@wlbragg
Copy link
Collaborator

wlbragg commented Apr 16, 2024

Revisiting this,

i don't know how you added it but i was thinking of something like this...

I actually like this. It is easy to read, even better with the bullets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants