Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimal singular value shrinkage for operator norm #492

Merged

Conversation

IlhaH
Copy link
Collaborator

@IlhaH IlhaH commented May 8, 2024

…h unit tests

This commit introduces a new function to perform singular value shrinkage using the method described in the paper "Optimal Singular Value Shrinkage for Operator Norm Loss" by William Leeb. The implemented shrinkage method is designed to be optimal for denoising low-rank matrices, particularly adjusting for different aspect ratios of matrices. The commit also includes unit tests that ensure the largest shrunken singular value does not deviate excessively.

…h unit tests

This commit introduces a new function to perform singular value shrinkage using the method described in the paper "Optimal Singular Value Shrinkage for Operator Norm Loss" by William Leeb. The implemented shrinkage method is designed to be optimal for denoising low-rank matrices, particularly adjusting for different aspect ratios of matrices. The commit also includes unit tests that ensure the largest shrunken singular value does not deviate excessively.
@austinTalbot7241993 austinTalbot7241993 changed the title Implement optimal singular value shrinkage for operator norm loss wit… Optimal singular value shrinkage for operator norm May 10, 2024
Copy link
Collaborator

@austinTalbot7241993 austinTalbot7241993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@austinTalbot7241993 austinTalbot7241993 merged commit bf0759f into bystrogenomics:master May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants