Add shellcheck ci #299
Draft
Add shellcheck ci #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 16, 2023 20:55
- change cpanm to cpm for faster building - minor tweaks to dist and cpanfile
- use tempdir for writing database - remove unused packages - organize package imports
- Use temporary directory for database - Use test helper library t/lib for common functions - Remove testing artifacts (i.e., test dbs) - Style imports to improve clarity - Remove some unused imports
|
This is awesome |
|
You're right about how it was added on top of other changes. It's just a single file so it could be added anytime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shell scripts should be checked, linted, or both. This is a simple github workflow for adding shell script checking. Adding linting with shfmt could be done, but, that will not address potentially problematic (usually non-portable) scripts in the same way so I think shellcheck is sufficient.