Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up bystro-utils #172

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Clean up bystro-utils #172

wants to merge 11 commits into from

Conversation

akotlar
Copy link
Collaborator

@akotlar akotlar commented Jul 23, 2023 •
edited

  • Update help message
  • Error early if the config file is defines a utils section with a member that doesn't have a name property
  • Use all CPU threads by default
  • In FilterCadd compress by default, to match SortCadd behavior

poneill
poneill suggested changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@poneill poneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused about what's happening with CI here: we're not running any checks. This, in turn, seems like two distinct issues:

  • we're not running perl tests
  • we're not running python tests. Even though the python tests aren't relevant to this PR, I don't think the github actions runner knows that yet? So I think we should iron out the CI issues here first.

@akotlar
Copy link
Collaborator Author

akotlar commented Jul 25, 2023

@poneill #177 will fix the GitHub actions issue. Nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poneill poneill poneill requested changes

@cristinaetrv cristinaetrv Awaiting requested review from cristinaetrv

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akotlar @poneill