Skip to content

Commit

Permalink
Adapt CI so it covers both new and old Macs, and installs required ad…
Browse files Browse the repository at this point in the history
…ditional dependencies on M1 (#408)

* naive attempt at adapting to silicon mac CI

* run include guard test on Silicon CI

* double-check hdf5 is needed
  • Loading branch information
alessandrofelder committed May 1, 2024
1 parent 0fd0a5e commit 6b529dc
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 6 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/test_and_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,14 @@ jobs:
# Run all supported Python versions on linux
os: [ubuntu-latest]
python-version: ["3.9", "3.10"]
# Include one windows, one macos run
# Include one windows, one macos run each for M1 (latest) and Intel (13)
include:
- os: macos-latest
python-version: "3.10"
- os: windows-latest
python-version: "3.10"
- os: macos-13
python-version: "3.10"
- os: macos-latest
python-version: "3.10"
- os: windows-latest
python-version: "3.10"

steps:
# Cache the tensorflow model so we don't have to remake it every time
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/test_include_guard.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,12 @@ jobs:
import cellfinder.core
import cellfinder.napari
- name: Uninstall tensorflow
- name: Uninstall tensorflow-macos on Mac M1
if: matrix.os == 'macos-latest'
run: python -m pip uninstall -y tensorflow-macos

- name: Uninstall tensorflow on Ubuntu
if: matrix.os == 'ubuntu-latest'
run: python -m pip uninstall -y tensorflow

- name: Test (broken) import
Expand Down

0 comments on commit 6b529dc

Please sign in to comment.