Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move resources to top level #345

Merged
merged 5 commits into from
May 16, 2024
Merged

Move resources to top level #345

merged 5 commits into from
May 16, 2024

Conversation

adamltyson
Copy link
Member

This PR moves the resources directory to the top level. It always struck me as strange that it was shipped with the package.

Tests and examples updated.

Closes #314

@adamltyson adamltyson requested a review from a team May 14, 2024 12:29
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.47%. Comparing base (42c3621) to head (b8176de).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   86.47%   86.47%           
=======================================
  Files          27       27           
  Lines        1220     1220           
=======================================
  Hits         1055     1055           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, with the intent of moving examples to docs, and test-data to GIN in the future.

@alessandrofelder alessandrofelder merged commit 004e84d into main May 16, 2024
13 checks passed
@alessandrofelder alessandrofelder deleted the resources branch May 16, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move example data out of the brainrender directory
2 participants