Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cellfinder_core to cellfinder #95

Merged
merged 4 commits into from May 2, 2024
Merged

Conversation

sfmig
Copy link
Contributor

@sfmig sfmig commented Apr 22, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
For consistency with the rest of the brainglobe tools.

What does this PR do?
Renames the workflow defined for cellfinder. The workflow was initially defined for cellfinder-core, the current backend of cellfinder.

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@sfmig sfmig force-pushed the smg/rename_cellfinder_workflow branch from 572efa1 to 10a1002 Compare April 22, 2024 17:26
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (34b07ec) to head (2e8da2b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files          17       17           
  Lines         862      862           
=======================================
  Hits          728      728           
  Misses        134      134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig force-pushed the smg/rename_cellfinder_workflow branch 2 times, most recently from 5c2ec2f to f1ea652 Compare April 25, 2024 10:53
@sfmig sfmig force-pushed the smg/rename_cellfinder_workflow branch from d6df9c9 to 2e8da2b Compare April 30, 2024 14:46
@sfmig sfmig marked this pull request as ready for review May 1, 2024 16:47
@sfmig sfmig requested a review from a team May 1, 2024 16:48
Copy link
Collaborator

@willGraham01 willGraham01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many cells shall be found.

@sfmig sfmig merged commit 918ac9f into main May 2, 2024
11 checks passed
@sfmig sfmig deleted the smg/rename_cellfinder_workflow branch May 2, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants