Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check asv benchmarks in CI #80

Closed
wants to merge 5 commits into from
Closed

Check asv benchmarks in CI #80

wants to merge 5 commits into from

Conversation

sfmig
Copy link
Contributor

@sfmig sfmig commented Jan 16, 2024

Add a CI step / job to check benchmarks are properly defined

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (cd14205) 79.43% compared to head (aa79561) 80.64%.

Files Patch % Lines
benchmarks/cellfinder_core.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   79.43%   80.64%   +1.20%     
==========================================
  Files          18       17       -1     
  Lines         924      899      -25     
==========================================
- Hits          734      725       -9     
+ Misses        190      174      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig
Copy link
Contributor Author

sfmig commented Apr 25, 2024

superseded by #96

@sfmig sfmig closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant