Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an example script for registration #16

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Sep 18, 2023

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

What does this PR do?

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

decided to keep everything here instead of in `brainglobe-scripts`
`brainglobe-scripts` is now obsolete.
@alessandrofelder alessandrofelder force-pushed the registration-script branch 3 times, most recently from 8a58688 to 4aa02d1 Compare September 18, 2023 15:34
@alessandrofelder alessandrofelder self-assigned this Sep 22, 2023
@adamltyson
Copy link
Member

@alessandrofelder before we need to start planning the 1st birthday party for this PR, do we still need it? I'm not clear on what it's for.

@alessandrofelder
Copy link
Member Author

Thanks for the reminder @adamltyson . The idea is that it will become an example script (that we can benchmark) for brainreg - similar to the cellfinder one that @sfmig is working on currently. So hopefully can be merged in the next few weeks with the focus on benchmarking :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Planned
Development

Successfully merging this pull request may close these issues.

None yet

2 participants