Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing human atlas script #290

Merged
merged 18 commits into from
May 20, 2024
Merged

Fixing human atlas script #290

merged 18 commits into from
May 20, 2024

Conversation

viktorpm
Copy link
Contributor

@viktorpm viktorpm commented May 14, 2024

Description

What is this PR?

  • Bug fix
  • Addition of a new feature
  • Other

What does this PR do?

How has this PR been tested?

  • locally
  • on the HPC
  • the regenerated atlas was validated

Is this a breaking change?

no

Does this PR require an update to the documentation?

no

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@viktorpm viktorpm marked this pull request as ready for review May 14, 2024 15:33
@viktorpm
Copy link
Contributor Author

Meshes and image extent don't match. It needs to be fixed.

@viktorpm
Copy link
Contributor Author

scaling is fixed

Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in person

  • it looks like we ignore the nifti header, and the raw array data is oriented in rpi
  • we should run again with this, and add this info the header
  • it would be useful to provide the whole brain in the script (not just one of the hemispheres)

annotations both hemisphere link: http://download.alleninstitute.org/informatics-archive/allen_human_reference_atlas_3d_2020/version_1/annotation_full.nii.gz

Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Also sanity check of the packaged atlas looks good. I'll let you upload to GIN and merge this when it's done @viktorpm . Thank you 🎉

@adamltyson
Copy link
Member

Thanks @viktorpm!

@viktorpm viktorpm merged commit f1efa8e into main May 20, 2024
10 of 11 checks passed
@viktorpm viktorpm deleted the fixing_human_atlas_script branch May 20, 2024 13:24
@adamltyson adamltyson mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate_atlases.py additional_references error
3 participants