Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[26.x] archive 26.1 release notes + backports #29899

Open
wants to merge 14 commits into
base: 26.x
Choose a base branch
from

Conversation

glozow and others added 3 commits April 17, 2024 13:28
To avoid issues with DNS blacklisting, I've setup a separate domain for my DNS seed.

Github-Pull: bitcoin#29691
Rebased-From: 4f273ab
@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 17, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

@bitcoin bitcoin deleted a comment from Joudyadam Apr 17, 2024
fanquake and others added 5 commits May 13, 2024 16:51
The issue is that compilation is done with `x86_64-w64-mingw32-g++-posix`,
but then linking is done with `x86_64-w64-mingw32-g++`.

I'm guessing this has been broken since bitcoin#24131
(01d1845), but have not checked.

Fixes bitcoin#29734.
Unblocks bitcoin#29527 (now DEBUG=1 builds can be tested).

Github-Pull: bitcoin#29747
Rebased-From: b7e7e72
The script provided for signature might be externally provided, for
instance by way of 'finalizepsbt'. Therefore the script might be
ill-crafted, so don't assume pubkeys are always 32 bytes.

Thanks to Niklas for finding this.

Github-Pull: bitcoin#29853
Rebased-From: 4d8d213
Re-enable feature_init

Github-Pull: bitcoin#29856
Rebased-From: fadf7e9
Pretty much all library packages were renamed in the 64-bit time_t
migration to add `t64` (even on 64-bit platforms).

Instead of complicating the doc with conditional package names, suggest
installing the `-dev` packages which still have the same name, and
besides that, are the right way to go about it as they contain the
"user facing" C++ headers needed to build against Qt5.

For Fedora, devel packages are already suggested.

This affects Ubuntu 24.04 and Debian Testing.

Github-Pull: bitcoin#29764
Rebased-From: a3c6a13
Fix CI build for t64 migration.

Github-Pull: bitcoin#29764
Rebased-From: 6c29904
laanwj and others added 3 commits May 14, 2024 10:47
The 32 to 64-bit time_t transition causes a build failure in the built-in
zlib about conflicting _TIME_BITS and _FILE_OFFSET_BITS.

Note that zlib doesn't use time_t at all, so it is a false alarm.

Take the following patch from upstream zlib:
https://github.com/madler/zlib/commit/a566e156b3fa07b566ddbf6801b517a9dba04fa3.patch

Closes bitcoin#29980.

Github-Pull: bitcoin#29985
Rebased-From: 2e266f3
Without explicitly declaring the move, these UniValues get copied,
causing increased memory usage. Fix this by explicitly moving the
UniValue objects.

Used by `rest_block` and `getblock` RPC.

Github-Pull: bitcoin#30094
Rebased-From: b77bad3
@glozow glozow marked this pull request as ready for review May 14, 2024 13:33
@jonatack
Copy link
Contributor

Propose the first commit of #30085 for backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet