doc: Suggest installing dev packages for debian/ubuntu qt5 build #29764

laanwj · 2024-03-29T08:34:39Z

Pretty much all library packages were renamed in the 64-bit time_t migration to add t64 (even on 64-bit platforms).

Instead of complicating the doc with conditional package names, suggest installing the -dev packages which still have the same name, and besides that, are the right way to go about it as they contain the "user facing" C++ headers needed to build against Qt5. They pull in the necessary library packages through dependencies.

For Fedora, devel packages are already suggested.

This affects Ubuntu 24.04 and Debian Testing.

Pretty much all library packages were renamed in the 64-bit time_t migration to add `t64` (even on 64-bit platforms). Instead of complicating the doc with conditional package names, suggest installing the `-dev` packages which still have the same name, and besides that, are the right way to go about it as they contain the "user facing" C++ headers needed to build against Qt5. For Fedora, devel packages are already suggested. This affects Ubuntu 24.04 and Debian Testing.

DrahtBot · 2024-03-29T08:34:42Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto, maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#28710 (Remove the legacy wallet and BDB dependency by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

maflcko · 2024-03-29T09:03:51Z

Nice catch. If you don't mind, can you please also update the CI environment at the same time? Currently it still passes, because the image is using a cache, and I presume the package rename happened recently. However, this may break at any time.

For reference, the CI failure is:

MAKEJOBS="-j$(nproc)" FILE_ENV="./ci/test/00_setup_env_native_tidy.sh" ./ci/test_run_all.sh

...

Reading package lists... Done
+ retry -- bash -c 'apt-get install --no-install-recommends --no-upgrade -y clang-18 libclang-18-dev llvm-18-dev libomp-18-dev clang-tidy-18 jq bear libevent-dev libboost-dev libminiupnpc-dev libnatpmp-dev libzmq3-dev systemtap-sdt-dev libqt5gui5 libqt5core5a libqt5dbus5 qttools5-dev qttools5-dev-tools libqrencode-dev libsqlite3-dev libdb++-dev build-essential libtool autotools-dev automake pkg-config bsdmainutils curl ca-certificates ccache python3 rsync git procps bison e2fsprogs cmake'
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Skipping ca-certificates, it is already installed and upgrade is not set.
ca-certificates set to manually installed.
Skipping python3, it is already installed and upgrade is not set.
Skipping rsync, it is already installed and upgrade is not set.
Skipping git, it is already installed and upgrade is not set.
Skipping procps, it is already installed and upgrade is not set.
Skipping e2fsprogs, it is already installed and upgrade is not set.
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 libqt5core5t64 : Breaks: libqt5core5a (< 5.15.12+dfsg-3ubuntu6)
 libqt5dbus5t64 : Breaks: libqt5dbus5 (< 5.15.12+dfsg-3ubuntu6)
 libqt5gui5t64 : Breaks: libqt5gui5 (< 5.15.12+dfsg-3ubuntu6)
E: Unable to correct problems, you have held broken packages.
Before retry #1: sleeping 0.3 seconds

...

hebasto · 2024-03-29T09:26:59Z

Concept ACK.

Fix CI build for t64 migration.

hebasto

ACK 6c29904.

maflcko · 2024-03-29T10:46:04Z

Thanks

lgtm ACK 6c29904

Pretty much all library packages were renamed in the 64-bit time_t migration to add `t64` (even on 64-bit platforms). Instead of complicating the doc with conditional package names, suggest installing the `-dev` packages which still have the same name, and besides that, are the right way to go about it as they contain the "user facing" C++ headers needed to build against Qt5. For Fedora, devel packages are already suggested. This affects Ubuntu 24.04 and Debian Testing. Github-Pull: bitcoin#29764 Rebased-From: a3c6a13

Fix CI build for t64 migration. Github-Pull: bitcoin#29764 Rebased-From: 6c29904

fanquake · 2024-04-01T14:06:52Z

Pulled into 27.x in #29780.

See bitcoin/bitcoin#29764

jonatack · 2024-04-01T16:22:28Z

Updated https://jonatack.github.io/articles/how-to-compile-bitcoin-core-and-run-the-tests. Thanks!

910e3e8 doc: update manual pages for v27.0 (fanquake) 2d2a0a3 build: bump version to v27.0 final (fanquake) 9442ea8 doc: import release notes from devwiki (fanquake) fe51ace Update the developer mailing list address. (Edil Medeiros) bde54b7 ci: Print tsan errors to stderr (MarcoFalke) 753c68d ci: Pull in qtbase5-dev instead of seperate low-level libraries (laanwj) c4da61b doc: Suggest installing dev packages for debian/ubuntu qt5 build (laanwj) Pull request description: Currently backports: * #29740 * #29764 * #29782 Pulls release notes: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/27.0-Release-Notes-Draft. Finalizes `v27.0`. ACKs for top commit: achow101: ACK 910e3e8 stickies-v: ACK 910e3e8 - no changes except addressing nits Tree-SHA512: 5dd8c6adaab154699f8ad9a5bda26de54901d3d1d09034a5a6775a37f12b44274d2d5ce6e1a527a6c211b56a75fe154f3ccb37bcbc39882be8299a4f127bfe30

Pretty much all library packages were renamed in the 64-bit time_t migration to add `t64` (even on 64-bit platforms). Instead of complicating the doc with conditional package names, suggest installing the `-dev` packages which still have the same name, and besides that, are the right way to go about it as they contain the "user facing" C++ headers needed to build against Qt5. For Fedora, devel packages are already suggested. This affects Ubuntu 24.04 and Debian Testing. Github-Pull: bitcoin#29764 Rebased-From: a3c6a13

Fix CI build for t64 migration. Github-Pull: bitcoin#29764 Rebased-From: 6c29904

glozow · 2024-05-14T09:42:44Z

backported to 26.x in #29899

Pretty much all library packages were renamed in the 64-bit time_t migration to add `t64` (even on 64-bit platforms). Instead of complicating the doc with conditional package names, suggest installing the `-dev` packages which still have the same name, and besides that, are the right way to go about it as they contain the "user facing" C++ headers needed to build against Qt5. For Fedora, devel packages are already suggested. This affects Ubuntu 24.04 and Debian Testing. Github-Pull: bitcoin#29764 Rebased-From: a3c6a13

Fix CI build for t64 migration. Github-Pull: bitcoin#29764 Rebased-From: 6c29904

aa7e876 [doc] add draft release notes for 26.2rc1 (glozow) 21d9aaa p2p, bugfix: detect addnode cjdns peers in GetAddedNodeInfo() (Jon Atack) ec5ce2f windeploy: Renew certificate (Ava Chow) 96d0e81 rpc: Reword SighashFromStr error message (MarcoFalke) 6685aff rpc: move UniValue in blockToJSON (willcl-ark) 7f45e00 depends: Fix build of Qt for 32-bit platforms (laanwj) f9b76ba ci: Pull in qtbase5-dev instead of seperate low-level libraries (laanwj) c587753 doc: Suggest installing dev packages for debian/ubuntu qt5 build (laanwj) 7ecdb08 ci: Bump s390x to ubuntu:24.04 (MarcoFalke) d9ef6cf sign: don't assume we are parsing a sane Miniscript (Antoine Poinsot) e4859c8 depends: fix mingw-w64 Qt DEBUG=1 build (fanquake) bb46b90 Fix #29767, set m_synced = true after Commit() (nanlour) bf5b6fc Throw error if invalid parameters passed to getnetworkhashps RPC endpoint (Jameson Lopp) a81a922 [rpc, bugfix] Enforce maximum value for setmocktime (dergoegge) d39ea51 Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us (Luke Dashjr) c21bbcc [doc] archive 26.1 release notes (glozow) Pull request description: Archives 26.1 release notes and adds draft release notes for 26.2rc1 Also backports: - #29691 - #29869 - #28554 - #29747 - #29853 - #29856 - #29764 - #29776 - #29985 - #30094 - #29870 - #30149 - #30085 ACKs for top commit: stickies-v: re-ACK aa7e876, only changes are fixing commit msg and transifex reference willcl-ark: ACK aa7e876 Tree-SHA512: b81ba6092640de696d782114cdf43e7ed1d63ea0a3231cade30653c2743d87700e0f852a1b1fcc42ae313b2d4f004e6026ddbad87d58c2fde0a660e90026ed98

DrahtBot added the Docs label Mar 29, 2024

maflcko added the Needs backport (26.x) label Mar 29, 2024

maflcko added this to the 27.0 milestone Mar 29, 2024

ci: Pull in qtbase5-dev instead of seperate low-level libraries

6c29904

Fix CI build for t64 migration.

hebasto approved these changes Mar 29, 2024

View reviewed changes

DrahtBot mentioned this pull request Mar 30, 2024

Remove the legacy wallet and BDB dependency #28710

Draft

fanquake merged commit b8420e4 into bitcoin:master Apr 1, 2024
16 checks passed

fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Apr 1, 2024

ci: Pull in qtbase5-dev instead of seperate low-level libraries

753c68d

Fix CI build for t64 migration. Github-Pull: bitcoin#29764 Rebased-From: 6c29904

fanquake mentioned this pull request Apr 1, 2024

[27.x] More backports and finalize #29780

Merged

jonatack added a commit to jonatack/jonatack.github.io that referenced this pull request Apr 1, 2024

How to Compile: use dev packages for debian/ubuntu qt5 build

a3a3448

See bitcoin/bitcoin#29764

glozow pushed a commit to glozow/bitcoin that referenced this pull request May 13, 2024

ci: Pull in qtbase5-dev instead of seperate low-level libraries

109b9d7

Fix CI build for t64 migration. Github-Pull: bitcoin#29764 Rebased-From: 6c29904

glozow mentioned this pull request May 14, 2024

[26.x] archive 26.1 release notes + backports #29899

Merged

glozow removed the Needs backport (26.x) label May 14, 2024

glozow pushed a commit to glozow/bitcoin that referenced this pull request May 23, 2024

ci: Pull in qtbase5-dev instead of seperate low-level libraries

f9b76ba

Fix CI build for t64 migration. Github-Pull: bitcoin#29764 Rebased-From: 6c29904

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: Suggest installing dev packages for debian/ubuntu qt5 build #29764

doc: Suggest installing dev packages for debian/ubuntu qt5 build #29764

laanwj commented Mar 29, 2024 •

edited

DrahtBot commented Mar 29, 2024 •

edited

maflcko commented Mar 29, 2024 •

edited

hebasto commented Mar 29, 2024

hebasto left a comment

maflcko commented Mar 29, 2024

fanquake commented Apr 1, 2024

jonatack commented Apr 1, 2024

glozow commented May 14, 2024

doc: Suggest installing dev packages for debian/ubuntu qt5 build #29764

doc: Suggest installing dev packages for debian/ubuntu qt5 build #29764

Conversation

laanwj commented Mar 29, 2024 • edited

DrahtBot commented Mar 29, 2024 • edited

Code Coverage

Reviews

Conflicts

maflcko commented Mar 29, 2024 • edited

hebasto commented Mar 29, 2024

hebasto left a comment

Choose a reason for hiding this comment

maflcko commented Mar 29, 2024

fanquake commented Apr 1, 2024

jonatack commented Apr 1, 2024

glozow commented May 14, 2024

laanwj commented Mar 29, 2024 •

edited

DrahtBot commented Mar 29, 2024 •

edited

maflcko commented Mar 29, 2024 •

edited