Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use readlink to properly source source dir #2036

Closed
wants to merge 1 commit into from
Closed

use readlink to properly source source dir #2036

wants to merge 1 commit into from

Conversation

mtdeguzis
Copy link

Adam bin scripts assume you are in the right directory. In standing this up in a docker container, we wanted a central source code location + symlinks to the in scripts. Using readlink, you can easily obtain the real directory.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@heuermh
Copy link
Member

heuermh commented Aug 29, 2018

Hello @mtdeguzis, thank you for the pull request.

We officially support the Docker images created by the BioContainer project
https://quay.io/repository/biocontainers/adam?tab=tags

which are generated from the ADAM Bioconda package
https://bioconda.github.io/recipes/adam/README.html

We have to include a patch in the Bioconda recipe to properly handle symlinks (issue #1973); I wonder if you think this would also help with that issue?

@heuermh
Copy link
Member

heuermh commented Aug 29, 2018

Jenkins, test this please.

@mtdeguzis
Copy link
Author

@heuermh , sure I don't mind helping. I will take a look a that linked issue tomorrow. Running out of time today. If you have anything specific to note, that will help.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2800/
Test PASSed.

@akmorrow13
Copy link
Contributor

This does not work on Mac. Generates error:

readlink: illegal option -- f
usage: readlink [-n] [file ...]
usage: dirname path

@mtdeguzis
Copy link
Author

@akmorrow13 , noted. I'll see what I can do to make the patch universal.

@heuermh
Copy link
Member

heuermh commented Jan 6, 2020

Closing as WontFix

@heuermh heuermh closed this Jan 6, 2020
@heuermh heuermh added this to the 0.31.0 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants