Support for configuring guard bars for EAN-13 #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjamro
changed the title
|
This looks like it would only apply to EAN/UPC barcodes which is fine. My only concern is that its configured on the outer barcode object and even if configured wouldnt do anything to any other types. Thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for configuring appearance of the guard bars for EAN-13 to match the standard. I need the first digit to be the same size as other digits and placed on the quiet area.
EAN-8 implementation will be similar. If you approve this approach i can make the necessary changes.
Default mode (backward compatible)
New mode - first char on the quiet zone
Because we need more space to fit the first char outside of the code a margin is added to both ends of the code. This could result in smaller code as on the image below.
Guard bars disabled