Center label relative to barcode #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjamro
force-pushed
the
feature/center-label
branch
from
cde1ea2
to
00bff1e
Compare
mjamro
force-pushed
the
feature/center-label
branch
3 times, most recently
from
466f9cd
to
244b421
Compare
barnhill
reviewed
Mar 31, 2024
|
|
||
| g.DrawRect(new SKRect(s1, img.Height - textBounds1.Height - textBounds1.Height / 4f, s1 + w1, img.Height), backBrush); // first guard bar cover | ||
|
|
||
| if (barcode.GuardBarsMode == GuardBarsMode.Enabled) |
There was a problem hiding this comment.
did this leak in from the other change for guard bars?
| @@ -207,7 +208,15 @@ public static SKImage Label_EAN13(Barcode barcode, SKBitmap img) | |||
| foreBrush.IsAutohinted = true; | |||
| foreBrush.FilterQuality = SKFilterQuality.High; | |||
|
|
|||
| g.DrawText(first, s1 + (w1 / 2f - textBounds1.Width / 2f), img.Height, foreBrush); | |||
| if (barcode.GuardBarsMode == GuardBarsMode.Enabled) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: The label text is rendered relative to the middle of the image instead of the middle of the actual barcode.
This PR requires #196
Current behaviour
Label text not in the middle of the barcode.
After changes
Label text in the middle of the barcode.