Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated install to emmc script #71

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jravetch
Copy link

@jravetch jravetch commented Dec 20, 2017

Opening a new PR to get the emmc install script added, based on comments #25

@ayufan ayufan force-pushed the master branch 2 times, most recently from d8a280d to 6d754f8 Compare January 11, 2018 13:57
@aw
Copy link
Contributor

aw commented Jan 14, 2018

@jravetch hey! ✨

@pfeerick
Copy link
Contributor

pfeerick commented Mar 16, 2018

The revised script is looking good. I think there is an issue with line 56 (suffix) though, as when I added xenial-containers as a supported image type it failed completely (couldn't find a matching image) until I changed it to arm64 instead of arm*. It otherwise worked fine OOTB.

@jravetch
Copy link
Author

Thanks @pfeerick for catching that. I've updated the script to reflect arm64.

@pfeerick
Copy link
Contributor

pfeerick commented Mar 18, 2018

No problem @jravetch ;) Can I also suggest (unless the advise has changed although it appears to still be valid from the latest release notes), that jessie-openmediavault be checked for before setting the suffix, so that an armhf suffix can be used if jessie-openmediavault is the image specified (maybe also add stretch-openmediavault and do the same for it since it's there for testing also now?). And that xenial-containers be added as an install option (as well as added to the help message). I'll give it another run through in a couple and days and prompt ayufan to review/include it...

@ayufan ayufan force-pushed the master branch 8 times, most recently from a4b291f to 1d02721 Compare April 1, 2018 18:15
@ayufan ayufan force-pushed the master branch 11 times, most recently from 092d477 to ead4abd Compare July 8, 2018 11:45
@ayufan ayufan force-pushed the master branch 3 times, most recently from 347392c to de16a9c Compare May 26, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants