Skip to content

Commit

Permalink
Remove '--amend' from release script
Browse files Browse the repository at this point in the history
  • Loading branch information
ayufan committed Jul 8, 2018
1 parent 259c9df commit 092d477
Showing 1 changed file with 3 additions and 19 deletions.
22 changes: 3 additions & 19 deletions do-release.bash
Expand Up @@ -5,7 +5,7 @@ if [[ "$DEBUG" == 1 ]]; then
fi

usage() {
echo "usage: $0 <release-version> [--amend] [--force] [--dry-run]"
echo "usage: $0 <release-version> [--force] [--dry-run]"
exit 1
}

Expand All @@ -18,7 +18,6 @@ COMMIT_FLAGS=""
TAG_FLAGS=""
PUSH_FLAGS=""
NO_DIRTY=1
AMEND=0
shift

for arg; do
Expand All @@ -33,13 +32,6 @@ for arg; do
PUSH_FLAGS="$PUSH_FLAGS --dry-run"
;;

--amend)
COMMIT_FLAGS="$COMMIT_FLAGS --amend"
TAG_FLAGS="$TAG_FLAGS --force"
PUSH_FLAGS="$PUSH_FLAGS --force"
AMEND=1
;;

*)
usage
;;
Expand All @@ -53,11 +45,6 @@ fi

set -e

if [[ "$AMEND" == "1" ]] && ! git show -s --format=%B | grep --quiet "^LATEST_"; then
echo "can only amend release commit"
exit 1
fi

echo "Edit changeset:"
if which editor &>/dev/null; then
editor RELEASE.md
Expand All @@ -79,11 +66,8 @@ git commit -m "Update RELEASE.md for $RELEASE"
echo "Creating tag..."
git add Makefile.versions.mk

echo "Creating temporary branch..."
git checkout $(git rev-parse HEAD) >/dev/null

echo "Committing $RELEASE..."
cat <<EOF | git commit $COMMIT_FLAGS -F -
cat <<EOF | git tag -a $TAG_FLAGS -F -
v$RELEASE
$(cat Makefile.versions.mk)
Expand All @@ -96,6 +80,6 @@ git checkout "master"

echo "Pushing..."
git push origin "$RELEASE" $PUSH_FLAGS
git push origin master
git push origin master $PUSH_FLAGS

echo "Done."

0 comments on commit 092d477

Please sign in to comment.