Python: add ZINTERCARD command #1418
Conversation
| @pytest.mark.parametrize("protocol", [ProtocolVersion.RESP2, ProtocolVersion.RESP3]) | ||
| async def test_zintercard(self, redis_client: TRedisClient): | ||
| min_version = "7.0.0" | ||
| if await check_if_server_version_lt(redis_client, min_version): |
There was a problem hiding this comment.
same, I think a function for that would be good
There was a problem hiding this comment.
I'm not sure I understand, can you clarify? Are you suggesting a skip_if_server_version_lt function that encapsulates lines 2528 to 2530?
There was a problem hiding this comment.
I'd like to see a function which run on the very beginning and sets a global value with the version.
Furthermore, in java, C# and go clients we check binary version, not what server returns.
There was a problem hiding this comment.
@shohamazon I suggest we merge this PR for now, you can answer my questions above and then we can go ahead and make the changes in all places that use these lines if we decide to go ahead
There was a problem hiding this comment.
@aaron-congo yes, skip_if_server_version_lt sounds good and could be vey useful
aaron-congo
force-pushed
the
python/integ_acongo_zintercard
branch
2 times, most recently
from
8cd83f8
to
4f65653
Compare
aaron-congo
force-pushed
the
python/integ_acongo_zintercard
branch
from
4f65653
to
0fbe5b0
Compare
aaron-congo
force-pushed
the
python/integ_acongo_zintercard
branch
from
501f6bc
to
e5f0da2
Compare
Issue #, if available:
N/A
Description of changes:
https://redis.io/docs/latest/commands/zintercard/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.