Python: add ZMPOP command #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-congo
requested review from
Yury-Fridlyand,
acarbonetto and
jonathanl-bq
and removed request for
Yury-Fridlyand
Yury-Fridlyand
approved these changes
May 16, 2024
I will fix it today |
|
#1419 will fix node failling |
shohamazon
approved these changes
May 16, 2024
Comment on lines
+2530
to
+2822
| if await check_if_server_version_lt(redis_client, min_version): | ||
| return pytest.mark.skip(reason=f"Redis version required >= {min_version}") |
There was a problem hiding this comment.
should we do that in a function? could be very useful
There was a problem hiding this comment.
Same question as here: #1418 (comment)
aaron-congo
force-pushed
the
python/integ_acongo_zmpop
branch
from
e96f3c8
to
7ce9e6f
Compare
aaron-congo
force-pushed
the
python/integ_acongo_zmpop
branch
from
9e477c9
to
8dc741f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
https://redis.io/docs/latest/commands/zmpop/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.