-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added check if tag include rc init, if so release as @next #1407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we set all RCs with the same next
tag, how can we release a new RC if there's one already exist?
@barshaul |
So in your solution the user passes the version with the RC number, right? and if the user passes an existing RC it would fail the workflow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See if using preid
can be better for use to use as it would enforce the right suffix, maybe by having two github tags for RC - one with the version and another with RC, to differentiate it from an actual release
d010a26
to
80fca16
Compare
Added option of release candidate to the CI.
If a tag including 'rc' in it it will set the publish tag to next, so it won't be install without specific direction.
To my understanding from https://pythonpackaging.info/07-Package-Release.html pypi automatically set version with -rc in their version as prerelease version.
@barshaul @shohamazon please check if i got it right.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.