NODE - test release candidate #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
approved these changes
May 14, 2024
barshaul
reviewed
May 19, 2024
barshaul
reviewed
May 19, 2024
barshaul
reviewed
May 19, 2024
barshaul
reviewed
May 19, 2024
barshaul
reviewed
May 19, 2024
barshaul
reviewed
May 19, 2024
barshaul
reviewed
May 19, 2024
avifenesh
force-pushed
the
CD/Feature/test-release-candidate
branch
from
c27c7fd
to
3c39c32
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
barshaul
requested changes
May 23, 2024
barshaul
reviewed
May 23, 2024
avifenesh
force-pushed
the
CD/Feature/test-release-candidate
branch
from
886df17
to
1a665c9
Compare
avifenesh
force-pushed
the
CD/Feature/test-release-candidate
branch
4 times, most recently
from
bfac1c9
to
7fa8a1c
Compare
avifenesh
force-pushed
the
CD/Feature/test-release-candidate
branch
8 times, most recently
from
bda3204
to
f04e7d6
Compare
avifenesh
force-pushed
the
CD/Feature/test-release-candidate
branch
10 times, most recently
from
3d92e97
to
a4eb6df
Compare
avifenesh
force-pushed
the
CD/Feature/test-release-candidate
branch
from
a4eb6df
to
307a1bc
Compare
barshaul
reviewed
May 26, 2024
barshaul
reviewed
May 26, 2024
barshaul
reviewed
May 26, 2024
barshaul
reviewed
May 26, 2024
barshaul
approved these changes
May 26, 2024
There was a problem hiding this comment.
Overall LGTM, but left some comments:
- Try to see if the matrix can be reformatted to be more readable
- Raise detailed error messages in the release-candidate-testing script (including the excepted response and the received one)
- Raise the error instead of just logging it - otherwise we won't fail the action when the tests are failing
- Some other minor comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added testing for release candidate publishing in node
Rebased over #1379 and #1407
Connected to #1177
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.