Iterative PSF fitting routine where all newly found sources are re-fit along with previously detected sources. #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Onoddil
changed the title
Onoddil
force-pushed
the
new_iterative_psf
branch
from
5caffe9
to
831b95a
Compare
…found sources along with any subsequently detected sources within image residuals.
Onoddil
force-pushed
the
new_iterative_psf
branch
from
831b95a
to
85c28d2
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial inclusion of a more robust PSF fitting algorithm, similar in scope to
IterativelySubtractedPSFPhotometry. However, instead of fitting sources, subtracting them and fitting sources found in the residual image,IterativeGroupPSFPhotometrylooks at the residual image for new sources, and then re-fits all sources in the subsequent loop.The loop then becomes
0) [find or provide initial sources]
1a) group sources
1b) fit sources in main image
1c) compute residual
1d) find new sources in residual
1e) [stop if no new sources]
2a) re-group sources
2b) re-fit sources in main image
2c) compute new residual
2d) find further sources in residual
...
This allows for the case where individual fitting of one PSF model to two overlapping sources would give unphysical parameters for the brightest source, providing a "second chance" to correct the derived parameters of the first source with the knowledge that there is a second source, previously hidden in the image. Because the fitting always occurs on the image, rather than the previous iteration's residuals, we do not propagate any poor fits from any prior loops forward.