Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionSegments to parameter list of cast function in MySQL visitor #30989

Closed
wants to merge 2 commits into from
Closed

Add functionSegments to parameter list of cast function in MySQL visitor #30989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dcf97d
add functionSegments to parameter list of cast function in MySQL visitor
Afsalmc Apr 22, 2024
210a7fc
code formatting corrections for stylecheck
Afsalmc Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...a/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/MySQLStatementVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,6 +1034,8 @@ public final ASTNode visitCastFunction(final CastFunctionContext ctx) {
result.getParameters().add((ColumnSegment) expr);
} else if (expr instanceof LiteralExpressionSegment) {
result.getParameters().add((LiteralExpressionSegment) expr);
} else if (expr instanceof FunctionSegment) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Afsalmc, does this change has sql parser test case cover?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strongduanmu No. I haven't made any changes to the test cases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is that after modifying the logic of visit, it needs to add the corresponding case to test it. Additionally, something went wrong with the CI, which also needed to be solved.

result.getParameters().add((FunctionSegment) expr);
}
}
if (null != ctx.castType()) {
Expand Down