Add functionSegments to parameter list of cast function in MySQL visitor #30989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strongduanmu
requested changes
Apr 23, 2024
| @@ -1034,8 +1034,7 @@ public final ASTNode visitCastFunction(final CastFunctionContext ctx) { | |||
| result.getParameters().add((ColumnSegment) expr); | |||
| } else if (expr instanceof LiteralExpressionSegment) { | |||
| result.getParameters().add((LiteralExpressionSegment) expr); | |||
| } | |||
| else if (expr instanceof FunctionSegment) { | |||
| } else if (expr instanceof FunctionSegment) { | |||
There was a problem hiding this comment.
Hi @Afsalmc, does this change has sql parser test case cover?
There was a problem hiding this comment.
@strongduanmu No. I haven't made any changes to the test cases.
There was a problem hiding this comment.
What I mean is that after modifying the logic of visit, it needs to add the corresponding case to test it. Additionally, something went wrong with the CI, which also needed to be solved.
|
Since this pr has long time no response, I will close it. You are welcome to submit a new PR and modify the comment issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.