Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon_color: updated for use in HA 0.110+ #185

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Mariusthvdb
Copy link

this re-instates customization of attribute icon_color in Ha 0.110

see: home-assistant/frontend#5892

this re-instates customization of attribute icon_color in Ha 0.110

see: home-assistant/frontend#5892
@bramkragten
Copy link

You should also change the source, not just the build output.

Needed for showing icon_color in HA 110 upward,
see home-assistant/frontend#5892 (comment)
@Mariusthvdb
Copy link
Author

thanks and I did,
please see this, about the es5.html file, do we need that after all, for the iPhone devices? home-assistant/frontend#5892 (comment)

to show correctly in /developer-tools/info
20200520-adapted-for-HA110+
@SupremeSports
Copy link

SupremeSports commented May 27, 2020

this re-instates customization of attribute icon_color in Ha 0.110

see: home-assistant/frontend#5892

Hi, sorry to ask, but I did copy the new version of the file you updated, but still no icon colors on either of my computers nor iPhone app... Is there something I'm not doing right???

EDIT: Fixed
Making the changes in 5892 and 6028 fixed everything for me :D

frontend:
  extra_module_url:
    - /local/custom_ui/state-card-custom-ui.js

@Mariusthvdb
Copy link
Author

check, see home-assistant/frontend#6028 (comment)

all fixed.

@Mariusthvdb
Copy link
Author

update: no longer need to use the frontend: method, but load via resources:
see my dedicated repo for easy downloading and instructions

@Mariusthvdb
Copy link
Author

Mariusthvdb commented Jun 14, 2020

HI Bram,

I was made aware that the custom card paper-buttons-row doesn't use the icon_color: setting customized by the new custom-ui card.

Maybe you changed anything in core that might have caused this? If so, could this be fixed in my custom-ui card as far as you know? Or would this be an issue for the paper-buttons-row card.

Please have a look if you can find a moment?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants