Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure double quotes are used for GA4 JSON #6756

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Ensure double quotes are used for GA4 JSON #6756

merged 1 commit into from
Apr 19, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Apr 18, 2024

Prevents JSON errors when a string within the JSON is using a single quote. E.g. if a text value was It's a nice day or this page: http://127.0.0.1:3010/check-building-safety-costs/y/yes/no/no/no/post_feb_2022/2020/140000.0/no/no/1500.0

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

Prevents JSON errors when a string within the JSON is using a single quote.
@AshGDS AshGDS self-assigned this Apr 18, 2024
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6756 April 18, 2024 16:15 Inactive
@AshGDS AshGDS requested a review from andysellick April 18, 2024 16:17
@AshGDS AshGDS merged commit 19bae70 into main Apr 19, 2024
17 checks passed
@AshGDS AshGDS deleted the ga4-json-fix branch April 19, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants