Merge pull request #6756 from alphagov/ga4-json-fix

Ensure double quotes are used for GA4 JSON
alphagov · Apr 19, 2024 · 19bae70 · 19bae70
2 parents 0df23a5 + 9b393c7
commit 19bae70
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 24 deletions.
diff --git a/app/views/smart_answers/custom_result.html.erb b/app/views/smart_answers/custom_result.html.erb
@@ -19,13 +19,13 @@
   <div
     class="govuk-grid-column-two-thirds"
     data-module="ga4-auto-tracker"
-    data-ga4-auto='{
+    data-ga4-auto="<%= {
       "event_name": "form_complete",
       "type": "smart answer",
-      "section": "<%= outcome.title %>",
+      "section": outcome.title,
       "action": "complete",
-      "tool_name": "<%= @presenter.title %>"
-    }'
+      "tool_name": @presenter.title
+    }.to_json %>"
   >
     <%= render "govuk_publishing_components/components/title", {
       title: outcome.title,

diff --git a/app/views/smart_answers/custom_result_full_width.erb b/app/views/smart_answers/custom_result_full_width.erb
@@ -26,13 +26,13 @@
   data-track-action="Completed"
   data-track-label="<%= @name %>"
   data-track-options='{"nonInteraction": true}'
-  data-ga4-auto='{
+  data-ga4-auto="<%={
     "event_name": "form_complete",
     "type": "smart answer",
-    "section": "<%= title %>",
+    "section": title,
     "action": "complete",
-    "tool_name": "<%= @presenter.title %>"
-  }'
+    "tool_name":  @presenter.title
+  }.to_json %>"
 >
   <%= render 'smart_answers/shared/debug' %>
   <%= render "govuk_publishing_components/components/title", {
@@ -46,13 +46,13 @@
     data-module="gem-track-click ga4-link-tracker"
     data-track-category="Internal Link Clicked"
     data-track-action="<%= @name %> results"
-    data-ga4-link='{
-      "event_name": "information_click", 
+    data-ga4-link="<%= {
+      "event_name": "information_click",
       "type": "smart answer",
-      "section": "<%= title %>", 
+      "section": title,
       "action": "information_click",
-      "tool_name": "<%= @presenter.title %>" 
-    }'
+      "tool_name": @presenter.title
+    }.to_json %>"
     data-ga4-track-links-only
     data-ga4-set-indexes
     data-track-links-only

diff --git a/app/views/smart_answers/result.html.erb b/app/views/smart_answers/result.html.erb
@@ -24,13 +24,13 @@
     data-track-action="Completed"
     data-track-label="<%= @name %>"
     data-track-options='{"nonInteraction": true}'
-    data-ga4-auto='{
+    data-ga4-auto="<%= {
       "event_name": "form_complete",
       "type": "smart answer",
-      "section": "<%= title %>",
+      "section": title,
       "action": "complete",
-      "tool_name": "<%= @presenter.title %>"
-    }'
+      "tool_name": @presenter.title
+    }.to_json %>"
     data-ecommerce-start-index="1"
     data-list-title="<%= @presenter.title %>"
     data-ga4-ecommerce-start-index="1"
@@ -48,13 +48,13 @@
       data-module="gem-track-click ga4-link-tracker"
       data-track-category="Internal Link Clicked"
       data-track-action="<%= @name %> results"
-      data-ga4-link='{
-      "event_name": "information_click",
-      "type": "smart answer",
-      "section": "<%= title %>",
-      "action": "information click",
-      "tool_name": "<%= @presenter.title %>"
-    }'
+      data-ga4-link="<%= {
+        "event_name": "information_click",
+        "type": "smart answer",
+        "section": title,
+        "action": "information click",
+        "tool_name": @presenter.title
+      }.to_json %>"
     data-ga4-track-links-only
     data-ga4-set-indexes
       data-track-links-only