[DO NOT MERGE] Spike font size changes (v2) #3819
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 12, 2024
matthillco
force-pushed
the
spike-font-size-changes-2
branch
from
cbd94c1
to
9990952
Compare
matthillco
force-pushed
the
spike-font-size-changes-2
branch
from
c1e9311
to
6c83871
Compare
matthillco
force-pushed
the
spike-font-size-changes-2
branch
from
2db2093
to
d8ee25f
Compare
matthillco
force-pushed
the
spike-font-size-changes-2
branch
from
d8ee25f
to
4b65e6c
Compare
matthillco
force-pushed
the
spike-font-size-changes-2
branch
from
4b65e6c
to
b8418ac
Compare
matthillco
force-pushed
the
spike-font-size-changes-2
branch
from
c1c93f1
to
a0c3e74
Compare
matthillco
force-pushed
the
spike-font-size-changes-2
branch
from
a0c3e74
to
84332b5
Compare
matthillco
force-pushed
the
spike-font-size-changes-2
branch
from
76f58e5
to
d8b3c23
Compare
matthillco
force-pushed
the
spike-font-size-changes-2
branch
from
d8b3c23
to
f0fac83
Compare
matthillco
force-pushed
the
spike-font-size-changes-2
branch
from
f0fac83
to
71e7654
Compare
matthillco
force-pushed
the
spike-font-size-changes-2
branch
from
71e7654
to
b1f3d3c
Compare
matthillco
force-pushed
the
spike-font-size-changes-2
branch
from
b1f3d3c
to
f0c0d60
Compare
These two elements became misaligned when the input field font-size was increased as part of the design system typography improvements. We no longer need adjusted padding for the tablet+ view as the font size is now the same 19px at all screen sizes.
Required to keep this branch working correctly.
Note these only show up due the way this branch needs to 'unignore' the node_modules folder for our original spike. It's not worth improving that at this point, and we'll be cherry picking only the good commits out of here for later deployment in their own feature branches.
I tried a couple of things here but ultimately the simplest solution was to ignore the smaller image sizes and remove the media device size media queries and instead use the larger sized logo by default.
matthillco
force-pushed
the
spike-font-size-changes-2
branch
from
c8fd710
to
8a6b030
Compare
matthillco
force-pushed
the
spike-font-size-changes-2
branch
from
8a6b030
to
844ca9b
Compare
matthillco
force-pushed
the
spike-font-size-changes-2
branch
from
844ca9b
to
5d08598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Temporary branch with font-size changes required for testing other apps. DO NOT MERGE.
This is v2 which includes the node_modules update for
stylistic.This branch includes manual changes to files in
govuk-frontendundernode_modules. The document Font sizes spike: Methodology has more information.NOTE that this spike is locked to v4.7.0 ofgovuk-frontend. This is partly because none of our apps are compatible with v5+ yet, and partly to keep maintenance low while we work on the font-size spikes.Updated to
govuk-frontendon 5/3/2024 as part of the work to fix font-size problems identified in the review.