-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Temporary branch for previewing font size changes #3270
Draft
matthillco
wants to merge
3
commits into
main
Choose a base branch
from
spike-font-size-changes-custom-gem
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthillco
added
the
do-not-merge
Indicates that a PR should not be merged into master / release branches
label
Feb 6, 2024
matthillco
force-pushed
the
spike-font-size-changes-custom-gem
branch
from
February 12, 2024 14:59
1af4cb7
to
50dd98f
Compare
matthillco
force-pushed
the
spike-font-size-changes-custom-gem
branch
from
March 5, 2024 11:28
50dd98f
to
30ebb33
Compare
matthillco
force-pushed
the
spike-font-size-changes-custom-gem
branch
from
March 6, 2024 14:34
30ebb33
to
4011f2d
Compare
matthillco
force-pushed
the
spike-font-size-changes-custom-gem
branch
from
April 4, 2024 09:37
4011f2d
to
12e8c7c
Compare
matthillco
force-pushed
the
spike-font-size-changes-custom-gem
branch
from
April 4, 2024 11:05
312d455
to
af5b063
Compare
matthillco
force-pushed
the
spike-font-size-changes-custom-gem
branch
from
April 4, 2024 11:17
af5b063
to
85fccc4
Compare
matthillco
force-pushed
the
spike-font-size-changes-custom-gem
branch
from
April 17, 2024 12:00
85fccc4
to
1445feb
Compare
* All 16px sizes increased to 19px in line with forthcoming DS changes * Extra top padding for first filter item, previously too short * Expander icons adjusted for better vertical alignment with text * Consistent spacing around second bold results text * Facets form now accounts for 2px shadow on the button
matthillco
force-pushed
the
spike-font-size-changes-custom-gem
branch
from
April 17, 2024 12:04
1445feb
to
291c747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Temporary branch for designers to review font size changes. DO NOT MERGE.
Uses a customised version of the gem from #3819 in the
govuk_publishing_components
. See that PR for more information.