Destinations CDK: Extract generation ID from catalog #38127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 10, 2024
gisripa
force-pushed
the
cdk_generation_id
branch
from
0122280
to
0379935
Compare
gisripa
force-pushed
the
cdk_generation_id
branch
from
3d4547a
to
0724d77
Compare
This was referenced May 10, 2024
gisripa
force-pushed
the
cdk_generation_id
branch
from
0724d77
to
0ded7a7
Compare
gisripa
force-pushed
the
cdk_generation_id
branch
from
0ded7a7
to
23a237f
Compare
gisripa
approved these changes
May 13, 2024
|
/publish-java-cdk
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CatalogParser extracts the generation IDs + sync ID from the catalog, and sets them on the StreamConfig
It defaults to generation_id = minimum_generation_id = 0; sync_id = 0 if the catalog has these values set to null.
We'll want to throw an exception later on, since that's our platform compatibility check (#38067). But for now, it's nicer to get some code onto master. 0 is a totally reasonable default, and lets us release the new columns into the wild even without platform support.