Destinations: Refreshes: CDK updates #38067
Draft
+16
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
3 times, most recently
from
9f8ae69
to
50c1e4b
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
50c1e4b
to
e857ce6
Compare
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
edgao
commented
May 8, 2024
| DestinationSyncMode.APPEND_DEDUP, | ||
| primaryKey, | ||
| Optional.of(cursor), | ||
| COLUMNS | ||
| COLUMNS, | ||
| 0, |
There was a problem hiding this comment.
maybe we should use nonzero generation id, so that tests are slightly more stringent?
edgao
commented
May 8, 2024
| DestinationSyncMode.OVERWRITE, | ||
| mock(), | ||
| mock(), | ||
| mock() | ||
| mock(), | ||
| 0, |
There was a problem hiding this comment.
for a later stacked PR: I think we need to add generation-related logic into DefaultTyperDeduper? so we'll want more test cases in this class...
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
e857ce6
to
982948e
Compare
edgao
commented
May 8, 2024
| import java.util.* | ||
| import kotlin.collections.LinkedHashMap | ||
|
|
||
| data class StreamConfig( | ||
| val id: StreamId, | ||
| val syncMode: SyncMode, |
There was a problem hiding this comment.
this is the source sync mode, which we should never look at. Delete it.
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
6 times, most recently
from
6839b3f
to
d361d45
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
3 times, most recently
from
a3bb96c
to
eca8010
Compare
edgao
force-pushed
the
edgao/catalog_parser_improvements
branch
from
7aff2a5
to
2047aec
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
eca8010
to
7058132
Compare
edgao
force-pushed
the
edgao/catalog_parser_improvements
branch
from
2047aec
to
2f4b6ac
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
7058132
to
1306644
Compare
2 tasks
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
29b9eb8
to
50418fc
Compare
edgao
force-pushed
the
edgao/async_tracking_stream_statuses
branch
from
6f4584b
to
9613270
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
50418fc
to
96c05b1
Compare
edgao
force-pushed
the
edgao/async_tracking_stream_statuses
branch
from
9613270
to
a906976
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
96c05b1
to
8660758
Compare
edgao
force-pushed
the
edgao/async_tracking_stream_statuses
branch
from
a906976
to
02bb59f
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
8660758
to
0ba6c7b
Compare
This was referenced May 21, 2024
| stream.syncId = 0 | ||
| // TODO set platform version | ||
| throw ConfigErrorException( | ||
| "You must upgrade your platform version to use this connector version. Either downgrade your connector or upgrade platform to X.Y.Z" |
There was a problem hiding this comment.
NIT: put an actual version?
edgao
force-pushed
the
edgao/async_tracking_stream_statuses
branch
from
02bb59f
to
45e05ef
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
0ba6c7b
to
3b692fc
Compare
edgao
force-pushed
the
edgao/async_tracking_stream_statuses
branch
from
45e05ef
to
d8c7059
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
3b692fc
to
066e07c
Compare
edgao
force-pushed
the
edgao/async_tracking_stream_statuses
branch
from
d8c7059
to
6a53eca
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
066e07c
to
79e5222
Compare
edgao
force-pushed
the
edgao/async_tracking_stream_statuses
branch
from
6a53eca
to
78a6637
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
79e5222
to
8136e82
Compare
edgao
force-pushed
the
edgao/async_tracking_stream_statuses
branch
from
78a6637
to
6a9a958
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
8136e82
to
25730e1
Compare
edgao
force-pushed
the
edgao/async_tracking_stream_statuses
branch
from
6a9a958
to
6388cd2
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
25730e1
to
1767d43
Compare
edgao
force-pushed
the
edgao/async_tracking_stream_statuses
branch
from
6388cd2
to
0da8739
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
1767d43
to
80eff9f
Compare
edgao
force-pushed
the
edgao/async_tracking_stream_statuses
branch
from
0da8739
to
e03f5fa
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
80eff9f
to
e2e12d8
Compare
edgao
changed the base branch from
edgao/async_tracking_stream_statuses
to
edgao/bigquery_more_cdk_bump
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/airbytehq/airbyte-internal-issues/issues/7606
These are the changes that break platform compatibility. We shouldn't release this until platform is ready for it, and we can turn on the
supportsRefreshesmetadata in destinations.