Fix how subscription packet length is calculated #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyeth
reviewed
Aug 31, 2023
tyeth
approved these changes
Aug 31, 2023
This was referenced Aug 31, 2023
Huzzah32 V2 + I2C sensor data no longer getting recorded
adafruit/Adafruit_Wippersnapper_Arduino#437
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request corrects how subscription packet length is calculated and increases the maximum buffer size for MCUs with more flash. It resolves an active WipperSnapper issue where large subscription packets (containing multiple i2c sensor initialization messages) fail to decode.
Resolves:
adafruit/Adafruit_Wippersnapper_Arduino#452
adafruit/Adafruit_Wippersnapper_Arduino#437
adafruit/Adafruit_Wippersnapper_Arduino#408