Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow - Remove Adafruit_MQTT_Library brentru fork, use adafruit upstream instead #478

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

brentru
Copy link
Member

@brentru brentru commented Aug 31, 2023

PR adafruit/Adafruit_MQTT_Library#227 brought the changes from the brentru/ fork of AMQTT upstream to the origin repository. This PR also includes changes for resolving the "I2C Packet Decode Error" persistent in WipperSnapper release builds.

This pull request removes the manual installation of the Adafruit MQTT Library (brentru fork) within the git workflow and instead

@brentru brentru requested a review from tyeth August 31, 2023 17:49
@brentru
Copy link
Member Author

brentru commented Aug 31, 2023

Waiting for https://www.arduinolibraries.info/libraries/adafruit-mqtt-library to pick up the latest release before re-running, testing on hardware and merging in..

Copy link
Contributor

@tyeth tyeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Reminds me when reading the whole file to look at the ci-arduino fork, and there are a couple of extra build targets eventually worth getting upstream too. The original adafruit repo is only used for SAMD currently so no issue.

@brentru brentru merged commit 90bf961 into adafruit:main Aug 31, 2023
24 checks passed
@brentru brentru deleted the remove-dep-for-brentru-fork-mqtt branch August 31, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants