Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify meaning of '!' at beginning of packet and allow '!' in the data. Also remove magic number. #32

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Clarify meaning of '!' at beginning of packet and allow '!' in the data. Also remove magic number. #32

wants to merge 9 commits into from

Commits on Mar 16, 2017

  1. An exclamation mark may legitimately be part of the data in the middl… 

    …e of the packet.
    @tedhenry100
    tedhenry100 committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    7f11ee0 View commit details
    Browse the repository at this point in the history

  2. An exclamation mark may legitimately be part of the data in the middl… 

    …e of the packet.
    @tedhenry100
    tedhenry100 committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    678efe6 View commit details
    Browse the repository at this point in the history

  3. An exclamation mark may legitimately be part of the data in the middl… 

    …e of the packet.
    @tedhenry100
    tedhenry100 committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    3581c33 View commit details
    Browse the repository at this point in the history

  4. Comment why we check that the packet starts with '!'.

    @tedhenry100
    tedhenry100 committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    0506538 View commit details
    Browse the repository at this point in the history

  5. Comment why we check that the packet starts with '!'.

    @tedhenry100
    tedhenry100 committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    b067537 View commit details
    Browse the repository at this point in the history

  6. Comment why we check that the packet starts with '!'.

    @tedhenry100
    tedhenry100 committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    dd149d6 View commit details
    Browse the repository at this point in the history

  7. Remove magic number that should be READ_BUFSIZE 

    If `READ_BUFSIZE` is defined to be less than 20, we don't want to read off the end of the buffer.

Fixes #30
    @tedhenry100
    tedhenry100 committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    933e6e2 View commit details
    Browse the repository at this point in the history

  8. Remove magic number that should be READ_BUFSIZE 

    If `READ_BUFSIZE` is defined to be less than 20, we don't want to read off the end of the buffer.

Fixes #30
    @tedhenry100
    tedhenry100 committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    868bfd4 View commit details
    Browse the repository at this point in the history

  9. Remove magic number that should be READ_BUFSIZE 

    If `READ_BUFSIZE` is defined to be less than 20, we don't want to read off the end of the buffer.

Fixes #30
    @tedhenry100
    tedhenry100 committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    77483b5 View commit details
    Browse the repository at this point in the history