Clarify meaning of '!' at beginning of packet and allow '!' in the data. Also remove magic number. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone more expert than me should definitely think about the change and test it more deeply. I'm no expert. In fact, that's exactly why I'm looking at the examples so I can model good quality code. 🙂 |
If `READ_BUFSIZE` is defined to be less than 20, we don't want to read off the end of the buffer. Fixes #30
If `READ_BUFSIZE` is defined to be less than 20, we don't want to read off the end of the buffer. Fixes #30
If `READ_BUFSIZE` is defined to be less than 20, we don't want to read off the end of the buffer. Fixes #30
tedhenry100
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23 and #31.
Also remove magic number to fix #30. (This is unrelated to #23 and #31 but I don't know how to create separate pull requests in GitHub while the first pull request is open.)