This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Adapting sendBeacon function for customizing output format of the request #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… formatResponse inside plugins. This open the posibilities for modifying the output format and adapt it to the required response. Signed-off-by: Nino Dafonte <nino.dafonte@gmail.com>
| @@ -95,7 +95,7 @@ boomr = { | |||
| } | |||
|
|
|||
| name = ' ' + name + '='; | |||
|
|
|||
There was a problem hiding this comment.
please fix all the white space changes. might be best to pull in the latest code from upstream first. also remember that we use tabs for indentation everywhere except when aligning variables.
|
I think maybe this should be split into two. The StatsPlus plugin which only adds the new parameters will be one part. For the second part, we'll need to look at making this into a MVC pattern, where the formatter would be the view. |
|
Yes, you are right, thank you Philip! |
|
Just wanted to let you know that this project is now at lognormal/boomerang, so would be good if you made your changes against that repository. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of the sendBeacon function for having the option for customizing formatResponse inside plugins.
This open the posibilities for modifying the output format and adapt it to the required response.
I'm trying to keep the gathering of statistical data as fast as possible and the goal is to insert the data in some noSql engine or Hadoop framework with a single request letting me make some post-processing. To do that, the url has to be in a specific format.
That's the reason for customizing the url format. I hope this could be helpful for another purposes.
Best regards, thank you very much.
pd: sorry for the bunch of line changes. My editor kills spaces and change them for tabs. I just wrote a comment to make the pull request more clear.