Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom beacon callback #1

Closed
vikstrous opened this issue Sep 6, 2012 · 3 comments
Closed

Custom beacon callback #1

vikstrous opened this issue Sep 6, 2012 · 3 comments
Labels
beacon RFE

Comments

@vikstrous
Copy link

I need the ability to pass in a custom beacon function into the configuration so that I can choose what format and what method is to be used to send the data to the backend. For example, I would like to send everything as a json using a POST, but this is not currently possible. I don't mind making the necessary modification myself. Let me know if there's anything I should know before I start.
@bluesmoon
Copy link
Member

The first thing that comes to mind is, can you use the before_beacon event and do it there?

If you'd like to write the code yourself, have a look at YahooArchive#21 that was posted on the original yahoo version of the code but never completed. If you could adapt that code into a plugin, I can merge it in.

@vikstrous
Copy link
Author

I made a pull request. I'm not sure how to link this ticket with it. #4

bluesmoon added a commit that referenced this issue Sep 18, 2012
@bluesmoon
Add v and u to params sent to before_beacon
bcad143 
`before_beacon` handlers should get access to all parameters that will
be added to the beacon url.  This includes the boomerang version and url
of the page (even though all handlers could just get this out of the
global space).

This of course means that we can no longer assume that v and u will be
the first two boomerang added parameters on the beacon.

Ref: Issue #1 and Issue #4
@bluesmoon
Copy link
Member

closing based on issue #4

bluesmoon added a commit that referenced this issue Aug 8, 2015
@bluesmoon
Add v and u to params sent to before_beacon
0c02dc3 
`before_beacon` handlers should get access to all parameters that will
be added to the beacon url.  This includes the boomerang version and url
of the page (even though all handlers could just get this out of the
global space).

This of course means that we can no longer assume that v and u will be
the first two boomerang added parameters on the beacon.

Ref: Issue #1 and Issue #4
@luckykurhe luckykurhe mentioned this issue May 17, 2016
Closed
cvazac added a commit that referenced this issue Oct 4, 2017
@cvazac
server timing merge #1
eb1b0d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beacon RFE
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bluesmoon @vikstrous