Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix k8s_force_delete_pod finalizers removal #189

Merged
merged 1 commit into from Mar 7, 2024
Merged

fix: Fix k8s_force_delete_pod finalizers removal #189

merged 1 commit into from Mar 7, 2024

Conversation

ekampf
Copy link
Contributor

@ekampf ekampf commented Mar 7, 2024

Changes

k8s_force_delete_pod was not deleting pod finalizers.
[] makes it merge the value with existing value instead of deleting it.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8195797720

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.517%
Totals Coverage Status
Change from base Build 8194940757: 0.0%
Covered Lines: 798
Relevant Lines: 809
💛 - Coveralls

minhtule
minhtule approved these changes Mar 7, 2024
View reviewed changes
Copy link

@minhtule minhtule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ekampf ekampf merged commit 5b2a8f3 into main Mar 7, 2024
12 checks passed
@ekampf ekampf deleted the fix/k8s_force_delete_pod branch March 7, 2024 22:46
@ekampf ekampf mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minhtule minhtule minhtule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ekampf @coveralls @minhtule