Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Integration test for old pod migration #190

Merged
merged 15 commits into from Mar 12, 2024

Conversation

ekampf
Copy link
Contributor

@ekampf ekampf commented Mar 7, 2024

Changes

Tests the fix of #189 by adding test_connector_flows_pod_migration_from_older_pod_with_finalizers.
We create a connector, patch the pod with a finalizer and wrong version annotation and make sure the reconciler is able to delete and recreate it.

@coveralls
Copy link
Collaborator

coveralls commented Mar 7, 2024

Pull Request Test Coverage Report for Build 8243850375

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.507%

Totals Coverage Status
Change from base Build 8241375508: 0.0%
Covered Lines: 796
Relevant Lines: 807

💛 - Coveralls

Copy link

@minhtule minhtule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ekampf ekampf force-pushed the chore/integration-test-for-pod-migration branch 2 times, most recently from b8cc877 to 536f496 Compare March 12, 2024 04:49
@ekampf ekampf force-pushed the chore/integration-test-for-pod-migration branch from b15d719 to f325286 Compare March 12, 2024 04:59
@ekampf ekampf merged commit 2dff2b3 into main Mar 12, 2024
16 checks passed
@ekampf ekampf deleted the chore/integration-test-for-pod-migration branch March 12, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants