Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improved TwingateConnector reconciliation #180

Merged
merged 15 commits into from Mar 5, 2024
Merged

feat: Improved TwingateConnector reconciliation #180

merged 15 commits into from Mar 5, 2024

Conversation

ekampf
Copy link
Contributor

@ekampf ekampf commented Mar 1, 2024 •
edited by minhtule

Changes

Replaced the complex mechanism of events we had to control TwingateConnector's pod lifecycle with a simple timer that runs every 5s and makes sure pod is alive and up to date

@coveralls
Copy link
Collaborator

coveralls commented Mar 1, 2024 •
edited

Pull Request Test Coverage Report for Build 8152741683

Details

  • 30 of 31 (96.77%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 96.538%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/handlers/handlers_connectors.py 30 31 96.77%
Totals Coverage Status
Change from base Build 8149364989: 0.02%
Covered Lines: 772
Relevant Lines: 790
💛 - Coveralls

@ekampf ekampf requested a review from minhtule March 2, 2024 03:20
minhtule
minhtule approved these changes Mar 5, 2024
View reviewed changes
Copy link

@minhtule minhtule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

app/handlers/handlers_connectors.py Outdated Show resolved Hide resolved
@ekampf ekampf merged commit e0a4f25 into main Mar 5, 2024
12 checks passed
@ekampf ekampf deleted the feature/connector-reconcile branch March 5, 2024 07:52
@ekampf ekampf mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minhtule minhtule minhtule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ekampf @coveralls @minhtule