Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make TwingateConnector's containerExtra and podExtra mutable #223

Merged
merged 3 commits into from Mar 26, 2024
Merged

feat: Make TwingateConnector's containerExtra and podExtra mutable #223

merged 3 commits into from Mar 26, 2024

Conversation

ekampf
Copy link
Contributor

@ekampf ekampf commented Mar 26, 2024 •
edited

Related Tickets & Documents

Fixes #215

Changes

  • Make containerExtra and podExtra mutable

The refactor in TwingateConnector reconciliation (#180) made this possible out of the box because we delete the pod and recreate it anyway on any update

@linear Linear
Copy link

linear bot commented Mar 26, 2024

OSS-22 Make connector `containerExtra` mutable

@coveralls
Copy link
Collaborator

coveralls commented Mar 26, 2024 •
edited

Pull Request Test Coverage Report for Build 8431077736

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.515%
Totals Coverage Status
Change from base Build 8428905058: 0.0%
Covered Lines: 799
Relevant Lines: 810
💛 - Coveralls

@ekampf ekampf marked this pull request as ready for review March 26, 2024 04:52
minhtule
minhtule approved these changes Mar 26, 2024
View reviewed changes
Copy link

@minhtule minhtule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ekampf ekampf changed the title feat: Make containerExtra and podExtra mutable feat: Make TwingateConnector's containerExtra and podExtra mutable Mar 26, 2024
@ekampf ekampf merged commit e7d8425 into main Mar 26, 2024
16 checks passed
@ekampf ekampf deleted the feature/oss-22-make-connector-containerextra-mutable branch March 26, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minhtule minhtule minhtule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make connector containerExtra mutable
3 participants
@ekampf @coveralls @minhtule